Arrow: remove dead code #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
danimtb
approved these changes
Apr 1, 2024
|
@danimtb this pr is targetting your fork, so no bot is going to merge it 😉 |
|
It'll merge into your pr conan-io#23163 |
danimtb
merged commit 926e8a0
into
danimtb:feature/arrow_options_refactor
5 checks passed
|
yes, I forgot to push the merge button 😅 thanks @ericLemanissier!! |
danimtb
added a commit
that referenced
this pull request
Apr 11, 2024
* Arrow: Refactor auto options * add todo * make boost compulsory in msvc * enable parquet and thrift by default * bump boost version to avoid conflicts with thrift's * try with re2 * bool compute * back to previous default values * avoid config * fix * Arrow: remove dead code (#6) * remove dead code * fix indentation * Update recipes/arrow/all/conanfile.py * remove warnings --------- Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: arrow/*
version is now always >= 7.0.0
@danimtb